sql: remove pointless Clock update closure allocation#57207
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 1, 2020
Merged
sql: remove pointless Clock update closure allocation#57207craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
yuzefovich
approved these changes
Nov 30, 2020
Member
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)
pkg/sql/distsql_running.go, line 544 at r1 (raw file):
// timestamp. Usually wraps an hlc.Clock. type clockUpdater interface { // Update updates this ClockUpdater with the the observed hlc.Timestamp.
nit: s/the the/the/.
Previously, we made a pointless closure on every query to update the hlc.Clock on receipt of new observed timestamps. This is pointless because we can be passing pre-allocated objects that can update themselves (most often the *hlc.Clock itself). Release note: None
Member
Author
|
tftr! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we made a pointless closure on every query to update the
hlc.Clock on receipt of new observed timestamps. This is pointless
because we can be passing pre-allocated objects that can update
themselves (most often the *hlc.Clock itself).
Release note: None