opt: don't hold on to evalCtx from detached Memo#57149
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 30, 2020
Merged
opt: don't hold on to evalCtx from detached Memo#57149craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This change adds more "cleanup" code when detaching a Memo (a detached memo is stored in the query cache and is reused later in a "read-only" fashion). In particular, we clear the EvalContext in logicalPropsBuilder which can lead to inadvertently holding on to a lot of memory. Fixes cockroachdb#57059. Release note: None
Member
Author
|
CC @ajwerner |
Member
|
This change is |
rytaft
approved these changes
Nov 30, 2020
Collaborator
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andy-kimball)
Member
Author
|
bors r+ |
This was referenced Nov 30, 2020
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds more "cleanup" code when detaching a Memo (a detached
memo is stored in the query cache and is reused later in a "read-only"
fashion). In particular, we clear the EvalContext in
logicalPropsBuilder which can lead to inadvertently holding on to a
lot of memory.
Fixes #57059.
Release note: None