Skip to content

sqlsmith: disallow crdb_internal.unsafe_* metadata mutation builtins#56914

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
thoszhang:remove-unsafe-builtins-from-sqlsmith
Nov 19, 2020
Merged

sqlsmith: disallow crdb_internal.unsafe_* metadata mutation builtins#56914
craig[bot] merged 1 commit intocockroachdb:masterfrom
thoszhang:remove-unsafe-builtins-from-sqlsmith

Conversation

@thoszhang
Copy link
Copy Markdown

Closes #56890.

Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@thoszhang thoszhang requested a review from ajwerner November 19, 2020 16:00
@thoszhang
Copy link
Copy Markdown
Author

I think this should work? I still need to test it.

Copy link
Copy Markdown
Member

@jordanlewis jordanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thoszhang
Copy link
Copy Markdown
Author

TFTR. I am actually not going to test this separately. Let's just see what happens tonight.

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 19, 2020

Build succeeded:

@craig craig bot merged commit c4032c2 into cockroachdb:master Nov 19, 2020
@thoszhang thoszhang deleted the remove-unsafe-builtins-from-sqlsmith branch November 19, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

roachtest: sqlsmith/setup=seed/setting=no-mutations failed

3 participants