Skip to content

sqlproxyccl: count successful connection attempts#56913

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
spaskob:sqlproxy-metric
Nov 20, 2020
Merged

sqlproxyccl: count successful connection attempts#56913
craig[bot] merged 1 commit intocockroachdb:masterfrom
spaskob:sqlproxy-metric

Conversation

@spaskob
Copy link
Copy Markdown
Contributor

@spaskob spaskob commented Nov 19, 2020

This counter will be useful to understand how many successful
connections have been cached so far unless we have gone over
the cache size limit of course.

Release note: none.

This counter will be useful to understand how many successful
connections have been cached so far unless we have gone over
the cache size limit of course.

Release note: none.
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown

@imjching imjching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@spaskob
Copy link
Copy Markdown
Contributor Author

spaskob commented Nov 19, 2020

TFTR!
bors=imjching

@spaskob
Copy link
Copy Markdown
Contributor Author

spaskob commented Nov 20, 2020

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 20, 2020

Build succeeded:

@craig craig bot merged commit 9806c1c into cockroachdb:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants