logictest: add retryable subtests#56841
Closed
jordanlewis wants to merge 1 commit intocockroachdb:masterfrom
Closed
logictest: add retryable subtests#56841jordanlewis wants to merge 1 commit intocockroachdb:masterfrom
jordanlewis wants to merge 1 commit intocockroachdb:masterfrom
Conversation
A retryable subtest is retried if a retriable (40001) error is encountered during the test. Fixes cockroachdb#56700. Fixes cockroachdb#53724. Release note: None
Member
|
This change is |
Member
Author
|
This is a PR for discussion. I'm not sure if it is such a good idea. |
ajwerner
reviewed
Nov 18, 2020
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Interesting. Should we disallow changing users and thus connections during such subtests?
Reviewable status:
complete! 0 of 0 LGTMs obtained
Member
Author
|
@ajwerner are we still interested in this? Are you satisfied with the other solution that you sent? |
Contributor
We could do better than that thing, but I don't want to merge this as is. Do you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A retryable subtest is retried if a retriable (40001) error is
encountered during the test.
Fixes #56700.
Fixes #53724.
Release note: None