teamcity-trigger: run nightly stressrace with -p 1#56775
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 24, 2020
Merged
teamcity-trigger: run nightly stressrace with -p 1#56775craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
andreimatei
commented
Nov 16, 2020
Contributor
Author
andreimatei
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jlinder, @nvanbenschoten, and @tbg)
pkg/cmd/teamcity-trigger/main.go, line 112 at r1 (raw file):
// Run race build. With run with -p 1 to avoid overloading the machine. noParallelism := 1 opts["env.GOFLAGS"] = fmt.Sprintf("-race -parallel=%d", parallelism)
I've let this be higher on purpose...
jlinder
approved these changes
Nov 17, 2020
Collaborator
jlinder
left a comment
There was a problem hiding this comment.
Seems like a reasonable approach to try.
Reviewable status:
tbg
approved these changes
Nov 19, 2020
5821969 to
190c9da
Compare
We're currently running with -p 2. We're seeing the TeamCity machines struggle with this - we're getting mysterious failures with logs spammed with slow requests and stalled disks. Fixes cockroachdb#56693 Fixes cockroachdb#56484 Fixes cockroachdb#56355 Tests found by searching for "disk slowness detected" and applying a modicum of common sense. Fixes cockroachdb#55404 Fixes cockroachdb#55418 Fixes cockroachdb#55420 Fixes cockroachdb#55421 Fixes cockroachdb#55423 Fixes cockroachdb#55574 Fixes cockroachdb#55627 Fixes cockroachdb#55799 Fixes cockroachdb#55884 Fixes cockroachdb#55930 Fixes cockroachdb#56037 Fixes cockroachdb#56106 Fixes cockroachdb#56172 Fixes cockroachdb#56274 Fixes cockroachdb#56402 Fixes cockroachdb#56702 Fixes cockroachdb#56704 Fixes cockroachdb#56717 Fixes cockroachdb#56794 Fixes cockroachdb#56889 Fixes cockroachdb#56891 Fixes cockroachdb#56946 Fixes cockroachdb#56990 Release note: None
190c9da to
40ab4eb
Compare
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're currently running with -p 2. We're seeing the TeamCity machines
struggle with this - we're getting mysterious failures with logs spammed
with slow requests and stalled disks.
Fixes #56693
Fixes #56484
Fixes #56355
Tests found by searching for "disk slowness detected" and applying a
modicum of common sense.
Fixes #55404
Fixes #55418
Fixes #55420
Fixes #55421
Fixes #55423
Fixes #55574
Fixes #55627
Fixes #55799
Fixes #55884
Fixes #55930
Fixes #56037
Fixes #56106
Fixes #56172
Fixes #56274
Fixes #56402
Fixes #56702
Fixes #56704
Release note: None