bazel: Move third party repositories to c-deps/REPOSITORIES.bzl#56525
bazel: Move third party repositories to c-deps/REPOSITORIES.bzl#56525craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I have added a few people who may be able to assist in reviewing:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
This change is |
a06bcd5 to
fc5f15c
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This is one of the Bazel re-factoring that we are working on and it is about to move third party repositories out of root WORKSPACE cockroachdb#56053 Best practices is to separate external dependencies and it also hides the repo WORKSPACE from beign used by other directories. We are creating a new .bzl file inside c-deps with all the external dependencies and then load then inside our root WORKSPACE Release note: None
fc5f15c to
4936cfe
Compare
|
@otan bors merge conflicts, should I need to do a rebase from upstream master? I am not able to see a log or something about the details. It only says "Permission denied" |
|
some other PR in the queue seems to merge conflict with this one (https://bors.crdb.io/repositories/56/log#batch-7255) |
|
Cool, then I will wait for bors to decide. |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
bazel: Move third party repositories to c-deps/REPOSITORIES.bzl
This is one of the Bazel re-factoring that we are working on
and it is about to move third party repositories out of root WORKSPACE.
fixes #56053
Best practices is to separate external dependencies and it also
hides the repo WORKSPACE from being used by other directories.
We are creating a new .bzl file inside c-deps with all the external dependencies
and then load then inside our root WORKSPACE
Release note: None