Skip to content

sqlsmith: add schema-related operations#56395

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
jordanlewis:sqlsmith-schemas
Nov 30, 2020
Merged

sqlsmith: add schema-related operations#56395
craig[bot] merged 1 commit intocockroachdb:masterfrom
jordanlewis:sqlsmith-schemas

Conversation

@jordanlewis
Copy link
Copy Markdown
Member

@jordanlewis jordanlewis commented Nov 6, 2020

User-defined schemas are now supported in sqlsmith. UDSs will be
randomly generated, and new tables will be randomly included in the
available UDSs. Queries will select from any table, including those
inside of UDSs as well.

Closes #54961.

Release note: None

User-defined schemas are now supported in sqlsmith. UDSs will be
randomly generated, and new tables will be randomly included in the
available UDSs. Queries will select from any table, including those
inside of UDSs as well.

Release note: None
@jordanlewis jordanlewis requested a review from a team November 6, 2020 23:37
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Direction: dir,
})
}
row := s.db.QueryRow(fmt.Sprintf(`
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't we need this 19.2 fallback logic any more?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so - each roachtest is run on its branch now, I thought.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, that was just changed in the beginning of november. so this lgtm

@jordanlewis
Copy link
Copy Markdown
Member Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 30, 2020

Build succeeded:

@craig craig bot merged commit 13ce0e8 into cockroachdb:master Nov 30, 2020
@jordanlewis jordanlewis deleted the sqlsmith-schemas branch December 1, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sqlsmith: handle user-defined schemas

3 participants