Skip to content

liveness: clean up BUILD gunk#56382

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:201106.liveness-bazel
Nov 6, 2020
Merged

liveness: clean up BUILD gunk#56382
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:201106.liveness-bazel

Conversation

@irfansharif
Copy link
Copy Markdown
Contributor

@irfansharif irfansharif commented Nov 6, 2020

We had this leftover gunk from when we originally named this package
nodeliveness (#56221). Seems like bazel regeneration did not strip it
all out when we moved things around.

Release note: None

@irfansharif irfansharif requested review from a team and andreimatei November 6, 2020 19:41
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Does gazelle generate these?

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)

@irfansharif
Copy link
Copy Markdown
Contributor Author

yup, through bazel run //:gazelle.

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 6, 2020

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 6, 2020

GitHub status checks took too long to complete, so bors is giving up. You can adjust bors configuration to have it wait longer if you like.

We had this leftover gunk from when we originally named this package
`nodeliveness`. Seems like bazel regeneration did not strip it all out
when we moved things around.

Release note: None
@irfansharif irfansharif force-pushed the 201106.liveness-bazel branch from 79871b0 to d9dd305 Compare November 6, 2020 20:37
@irfansharif
Copy link
Copy Markdown
Contributor Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 6, 2020

Build succeeded:

@craig craig bot merged commit 9bd5b44 into cockroachdb:master Nov 6, 2020
@irfansharif irfansharif deleted the 201106.liveness-bazel branch November 6, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants