[wip] backupccl: test transaction retryability in backupccl#56074
Closed
pbardea wants to merge 2 commits intocockroachdb:masterfrom
Closed
[wip] backupccl: test transaction retryability in backupccl#56074pbardea wants to merge 2 commits intocockroachdb:masterfrom
pbardea wants to merge 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
|
I just happened to see this, but it looks cool. How much overlap does it have with #54695? |
Contributor
Author
|
Sorry, I missed your comment on this one. I think that there's quite a bit of overlap, I think that the other PR would be more general. I'll comment over there to see what blockers there are in terms of merging that and starting to use that knob in tests. |
Contributor
|
I tried #54695 once and found some bugs using it. |
d929693 to
9757dc4
Compare
This commit adds an interface that can be used to store key-value pairs which can be adjusted during testing. This provides a lighter-weight version of testing knobs. Release note: None
9757dc4 to
64af3b7
Compare
This commit adds a test setting so that backupccl tests exercise the case where transaction retry during backup/restore. Release note: None
64af3b7 to
318faf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a test setting so that backupccl tests exercise the
case where transaction retry during backup/restore.
This is a very early prototype... mainly to gather feedback/thoughts.
Naming and general organization needs to be changed.
Release note: None