build: add instructions to rectify code that is not regenerated#56004
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 27, 2020
Merged
build: add instructions to rectify code that is not regenerated#56004craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
Author
|
(failure example: #56005) |
irfansharif
approved these changes
Oct 26, 2020
build/teamcity-check.sh
Outdated
| run build/builder.sh make generate &> artifacts/generate.log || (cat artifacts/generate.log && false) | ||
| run build/builder.sh make buildshort &> artifacts/buildshort.log || (cat artifacts/buildshort.log && false) | ||
| rm artifacts/generate.log | ||
| check_clean "Run \`make generate\` to automatically fix these. For only BUILD.bazel issues, run \`bazel run //:gazelle\`." |
Contributor
There was a problem hiding this comment.
I'd also be fine with suggesting make bazel-generate here.
Contributor
Author
There was a problem hiding this comment.
have to teach people to stop using make somehow :P
ead0b9d to
0faa730
Compare
Make it easier for the developer to know how to fix un-generated code by specifying the required commands. Release note: None
Contributor
Author
|
bors r=irfansharif |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it easier for the developer to know how to fix un-generated code by
specifying the required commands.
Release note: None