Skip to content

roachtest: use IMPORT for all TPC-C tests#55982

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/tpccImportMore
Oct 27, 2020
Merged

roachtest: use IMPORT for all TPC-C tests#55982
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/tpccImportMore

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Oct 26, 2020

Fixes #55541.
Fixes #55580.

In #54880 and #55050, we switched to using IMPORT for most TPC-C tests,
in favor of BACKUP, which requires fixtures to be regenerated whenever
we changed the workload. In this PR, we switch over the remaining uses
of fixtures load tpcc to fixtures import tpcc to avoid compatibility
issues on older release branches.

Fixes cockroachdb#55541.
Fixes cockroachdb#55580.

In cockroachdb#54880 and cockroachdb#55050, we switched to using IMPORT for most TPC-C tests,
in favor of BACKUP, which requires fixtures to be regenerated whenever
we changed the workload. In this PR, we switch over the remaining uses
of `fixtures load tpcc` to `fixtures import tpcc` to avoid compatibility
issues on older release branches.
@nvb nvb requested a review from tbg October 26, 2020 16:35
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented Oct 27, 2020

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Oct 27, 2020

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Oct 27, 2020

Build succeeded:

@craig craig bot merged commit b319a0b into cockroachdb:master Oct 27, 2020
@nvb nvb deleted the nvanbenschoten/tpccImportMore branch November 12, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

roachtest: drop/tpcc/w=100,nodes=9 failed roachtest: drop/tpcc/w=100,nodes=9 failed

3 participants