roachprod: Configure Azure disks.#55975
Conversation
|
This change is |
arulajmani
left a comment
There was a problem hiding this comment.
LGTM modulo one suggestion.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @arulajmani and @miretskiy)
pkg/cmd/roachprod/vm/azure/azure.go, line 595 at r1 (raw file):
case "premium-disk": storageAccType = compute.StorageAccountTypesPremiumLRS caching = compute.CachingTypesReadOnly
Can we make this configurable and have it default to None? Considering how many times we've gotten burned by hard coded things in roachprod, I think we should surface this to users rather than have them find this "magic" only if they go digging in.
|
Done. Added --azure-disk-caching flag. |
arulajmani
left a comment
There was a problem hiding this comment.
Thanks! one nit but otherwise this should be good to merge.
Reviewable status:
pkg/cmd/roachprod/vm/azure/azure.go, line 605 at r2 (raw file):
caching = compute.CachingTypesReadOnly case "read-write": caching = compute.CachingTypesReadWrite
nit: could you add a case for None and a default option so that if the user makes a typo or something they're informed rather than surprised?
|
done. |
Add ability to specify the size of the attached disks for Azure. Use read only caching for Azure premium disks. Release Notes: None
arulajmani
left a comment
There was a problem hiding this comment.
Reviewable status:
|
bors r+ |
|
Build succeeded: |
Add ability to specify the size of the attached disks for Azure.
Use read only caching for Azure premium disks.
Release Notes: None