Skip to content

c-deps: remove googletest#55900

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:201023.rm-googletest
Oct 23, 2020
Merged

c-deps: remove googletest#55900
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:201023.rm-googletest

Conversation

@irfansharif
Copy link
Copy Markdown
Contributor

We don't need it anymore. We originally introduced it to support tests
in libroach (#20594), which has since been pared down to something much
simpler (#55509, just DBDumpThreadStacks).

Release note: None

We don't need it anymore. We originally introduced it to support tests
in libroach (cockroachdb#20594), which has since been pared down to something much
simpler (cockroachdb#55509, just DBDumpThreadStacks).

Release note: None
@irfansharif irfansharif requested a review from itsbilal October 23, 2020 16:31
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @itsbilal)

@irfansharif
Copy link
Copy Markdown
Contributor Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Oct 23, 2020

Build succeeded:

@craig craig bot merged commit da45387 into cockroachdb:master Oct 23, 2020
@irfansharif irfansharif deleted the 201023.rm-googletest branch October 23, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants