*: Remove cryptopp from c-deps, stop building it#55858
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 22, 2020
Merged
*: Remove cryptopp from c-deps, stop building it#55858craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
libcryptopp was only used for RocksDB encryption-at-rest. Now that RocksDB is deleted (cockroachdb#55509), we can remove libcryptopp too. Release note: None.
Member
|
This change is |
petermattis
reviewed
Oct 22, 2020
Collaborator
petermattis
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jbowens, @otan, and @petermattis)
petermattis
approved these changes
Oct 22, 2020
Member
|
This is like CockroachDB Christmas! |
Contributor
|
In time for Halloween, we can dress up as the ghost of RocksDB |
Contributor
Author
|
TFTR! 🎃 bors r=petermattis |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libcryptopp was only used for RocksDB encryption-at-rest. Now
that RocksDB is deleted (#55509), we can remove libcryptopp too.
Release note: None.