Skip to content

build: add bazel-3.7.0 to builder image#55790

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
otan-cockroach:bazel-in-builder
Oct 21, 2020
Merged

build: add bazel-3.7.0 to builder image#55790
craig[bot] merged 1 commit intocockroachdb:masterfrom
otan-cockroach:bazel-in-builder

Conversation

@otan
Copy link
Copy Markdown
Contributor

@otan otan commented Oct 21, 2020

Resolves #55693

Release note: None

@otan otan requested review from irfansharif and jlinder October 21, 2020 00:19
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Oct 21, 2020

This change is Reviewable

irfansharif
irfansharif approved these changes Oct 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@irfansharif irfansharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐶 🔍

@otan
Copy link
Copy Markdown
Contributor Author

otan commented Oct 21, 2020 

        lint_test.go:86: 
            In file included from ../server/status/runtime_jemalloc.go:20:
            /go/native/x86_64-pc-linux-gnu/jemalloc/include/jemalloc/jemalloc.h:198:46: warning: unknown attribute 'alloc_size' ignored [-Wunknown-attributes]
            /go/native/x86_64-pc-linux-gnu/jemalloc/include/jemalloc/jemalloc.h:152:50: note: expanded from macro 'JEMALLOC_ALLOC_SIZE'
            /go/native/x86_64-pc-linux-gnu/jemalloc/include/jemalloc/jemalloc.h:201:46: warning: unknown attribute 'alloc_size' ignored [-Wunknown-attributes]
            /go/native/x86_64-pc-linux-gnu/jemalloc/include/jemalloc/jemalloc.h:153:56: note: expanded from macro 'JEMALLOC_ALLOC_SIZE2'
            /go/native/x86_64-pc-linux-gnu/jemalloc/include/jemalloc/jemalloc.h:207:5: warning: unknown attribute 'alloc_size' ignored [-Wunknown-attributes]
            /go/native/x86_64-pc-linux-gnu/jemalloc/include/jemalloc/jemalloc.h:152:50: note: expanded from macro 'JEMALLOC_ALLOC_SIZE'
            /go/native/x86_64-pc-linux-gnu/jemalloc/include/jemalloc/jemalloc.h:210:24: warning: unknown attribute 'alloc_size' ignored [-Wunknown-attributes]
            /go/native/x86_64-pc-linux-gnu/jemalloc/include/jemalloc/jemalloc.h:152:50: note: expanded from macro 'JEMALLOC_ALLOC_SIZE'
            /go/native/x86_64-pc-linux-gnu/jemalloc/include/jemalloc/jemalloc.h:216:27: warning: unknown attribute 'alloc_size' ignored [-Wunknown-attributes]
            /go/native/x86_64-pc-linux-gnu/jemalloc/include/jemalloc/jemalloc.h:152:50: note: expanded from macro 'JEMALLOC_ALLOC_SIZE'
            /go/native/x86_64-pc-linux-gnu/jemalloc/include/jemalloc/jemalloc.h:219:16: warning: unknown attribute 'alloc_size' ignored [-Wunknown-attributes]
            /go/native/x86_64-pc-linux-gnu/jemalloc/include/jemalloc/jemalloc.h:152:50: note: expanded from macro 'JEMALLOC_ALLOC_SIZE'

.... o_o"

@otan otan force-pushed the bazel-in-builder branch 2 times, most recently from 2c5b9ec to 83457de Compare October 21, 2020 02:22
@otan otan requested a review from a team as a code owner October 21, 2020 02:22
@otan otan force-pushed the bazel-in-builder branch 2 times, most recently from 64720e2 to 9a53ed7 Compare October 21, 2020 03:01
@otan otan force-pushed the bazel-in-builder branch from 9a53ed7 to cf4de10 Compare October 21, 2020 05:53
@otan
Copy link
Copy Markdown
Contributor Author

otan commented Oct 21, 2020

bors r=irfansharif,jlinder

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Oct 21, 2020

Build succeeded:

@craig craig bot merged commit c638b8e into cockroachdb:master Oct 21, 2020
@irfansharif irfansharif mentioned this pull request Oct 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlinder jlinder jlinder approved these changes

+1 more reviewer

@irfansharif irfansharif irfansharif approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

build: Add bazel to the builder image

4 participants

@otan @cockroach-teamcity @jlinder @irfansharif