backupccl: only restore system tables included in backup#55685
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Oct 20, 2020
Merged
backupccl: only restore system tables included in backup#55685craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
7cc8c21 to
d93370f
Compare
Contributor
Author
|
This is an initial stab at it, but wanted to solicit any feedback early on. Adding x-version testing now for cluster restore. |
miretskiy
approved these changes
Oct 19, 2020
Contributor
miretskiy
left a comment
There was a problem hiding this comment.
Looks reasonable to me on the first pass. Let's see the tests.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @dt, @miretskiy, and @pbardea)
pkg/ccl/backupccl/restore_old_versions_test.go, line 107 at r1 (raw file):
) //
extra comment?
d93370f to
5e41462
Compare
Contributor
Author
|
Update: pushed the test, but now it looks like DROP DATABASE jobs are hanging as soon as we restore any system table data from the test backup. Investigating. |
319f7c5 to
684ea08
Compare
dt
approved these changes
Oct 19, 2020
042f70a to
97cb3e4
Compare
Including the cluster version in cluster restore might decrease the cluster version. We have seen this cause issues where DROP DATABASES stop working. Release note: None
Before this commit, we would assume that all of the system tables that we wanted to restore were present in the backup. However, this is not necessarily true since system tables can be added between releases. Release note (bug fix): Previously cluster backups taken from before 20.2 could not be restored in 20.2 clusters, with an error message about failing to restore a system table. This is now fixed.
97cb3e4 to
3d920ee
Compare
Contributor
Author
|
TFTRs! |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, we would assume that all of the system tables that
we wanted to restore were present in the backup. However, this is not
necessarily true since system tables can be added between releases.
Release note (bug fix): Previously cluster backups taken from before
20.2 could not be restored in 20.2 clusters, with an error message about
failing to restore a system table. This is now fixed.