xform: organize custom functions into general_funcs.go and scan_funcs.go#55655
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Oct 20, 2020
Merged
xform: organize custom functions into general_funcs.go and scan_funcs.go#55655craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
This is in preparation for breaking up the custom functions into multiple files, similar to the organization of normalization custom functions. Release note: None
This is one step in breaking up the exploration custom functions into files based on the rules they facilitate, similar to the normalization custom functions. Release note: None
Member
|
This change is |
RaduBerinde
approved these changes
Oct 18, 2020
Member
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rytaft)
Contributor
Author
|
bors r=RaduBerinde |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This was referenced Nov 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xform: rename custom_funcs.go to general_funcs.go
This is in preparation for breaking up the custom functions into
multiple files, similar to the organization of normalization custom
functions.
Release note: None
xform: move scan-related custom functions to scan_funcs.go
This is one step in breaking up the exploration custom functions into
files based on the rules they facilitate, similar to the normalization
custom functions.
Release note: None