kvserver: implement Liveness.String() on value receiver#55620
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 16, 2020
Merged
kvserver: implement Liveness.String() on value receiver#55620craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
The usual problem with only the pointer implementing Stringer. Particularly important since NodeLiveness.GetLivenes() returns a value Liveness. It used to be implemented on values, but that changed in cockroachdb#50329 for some reason. Release note: None
Member
|
This change is |
irfansharif
approved these changes
Oct 15, 2020
andreimatei
commented
Oct 16, 2020
Contributor
Author
andreimatei
left a comment
There was a problem hiding this comment.
bors r+
Reviewable status:
complete! 0 of 0 LGTMs obtained
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usual problem with only the pointer implementing Stringer.
Particularly important since NodeLiveness.GetLivenes() returns a value
Liveness.
It used to be implemented on values, but that changed in #50329 for some
reason.
Release note: None