docker: Switch to using ubi8/ubi-minimal#55467
Conversation
|
This change is |
bdarnell
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @bdarnell and @jlinder)
build/deploy/Dockerfile, line 1 at r1 (raw file):
FROM registry.access.redhat.com/ubi8/ubi-minimal AS builder
Maybe just use the non-minimal UBI as the builder? (unless you want to use one of the tricks from my other comment to avoid the separate builder image)
build/deploy/Dockerfile, line 11 at r1 (raw file):
# For deployment, we need the following installed (they are installed # by default in RedHat UBI standard):
This comment could use an update.
Before: We were using ubi8/ubi because we hadn't figured out how to get tzdata into the ubi8/ubi-minimal image. Why: The ubi8/ubi-minimal image is smaller and now has everything we need. Now: The docker image is based on ubi8/ubi-minimal. The required tzdata files are acquired by rpm erasing the tzdata package and then reinstalling it (there is no `microdnf reinstall` command in the current image). Release note (backward-incompatible change): The docker image is now based on RedHat's ubi8/ubi-minimal image (instead of ubi8/ubi). This image is smaller.
4676a09 to
6b64490
Compare
jlinder
left a comment
There was a problem hiding this comment.
Reviewable status:
build/deploy/Dockerfile, line 1 at r1 (raw file):
Previously, bdarnell (Ben Darnell) wrote…
Maybe just use the non-minimal UBI as the builder? (unless you want to use one of the tricks from my other comment to avoid the separate builder image)
I switched to using the rpm erase hack you noted in #54812.
build/deploy/Dockerfile, line 11 at r1 (raw file):
Previously, bdarnell (Ben Darnell) wrote…
This comment could use an update.
Updated.
|
Josh and Joel, The change to using the |
|
TFTR! bors r=bdarnell |
|
Tested on our Helm chart and on CC, both work as expected with this change. |
|
Build succeeded: |
Before: We were using ubi8/ubi because we hadn't figured out how to get
tzdata into the ubi8/ubi-minimal image.
Why: The ubi8/ubi-minimal image is smaller and now has everything we
need.
Now: The docker image is based on ubi8/ubi-minimal. The required tzdata
files are acquired by rpm erasing the tzdata package and then
reinstalling it (there is no
microdnf reinstallcommand in the currentimage).
Release note (backward-incompatible change): The docker image is now
based on RedHat's ubi8/ubi-minimal image (instead of ubi8/ubi). This
image is smaller.