server: create engines in NewServer#55277
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 7, 2020
Merged
Conversation
We were jumping through a number of hoops to create the engines only in `(*Server).Start` since that seems to be the "idiomatic" place to start moving parts. However, it creates a lot of complexity since various callbacks have to be registered with access to engines. Move engine creation to `NewServer`. This unblocks cockroachdb#54936. Release note: None
Member
|
This change is |
irfansharif
approved these changes
Oct 7, 2020
Member
Author
|
bors r=irfansharif |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were jumping through a number of hoops to create the engines only in
(*Server).Startsince that seems to be the "idiomatic" place to startmoving parts. However, it creates a lot of complexity since various
callbacks have to be registered with access to engines. Move engine
creation to
NewServer.This unblocks #54936.
Release note: None