roachtest: bump fixtures for 20.1 (to 20.1.6)#55253
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 7, 2020
Merged
roachtest: bump fixtures for 20.1 (to 20.1.6)#55253craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
arulajmani
approved these changes
Oct 6, 2020
Collaborator
arulajmani
left a comment
There was a problem hiding this comment.
Thanks for helping dig into this.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @arulajmani, @irfansharif, and @tbg)
pkg/cmd/roachtest/versionupgrade.go, line 523 at r1 (raw file):
for i in 1 2 3 4; do mkdir -p pkg/cmd/roachtest/fixtures/${i} && \ mv artifacts/acceptance/version-upgrade/run_1/${i}.logs/checkpoint-*.tgz \
Could you update this to mv artifacts/acceptance/version-upgrade/run_1/logs/${i}.unredacted/checkpoint-*.tgz \ while we're here as well?
And address fallout from `roachprod` changes around cluster initialization (cockroachdb#51329). Touches cockroachdb#54761. Release note: None
0fa6285 to
33b371f
Compare
irfansharif
commented
Oct 7, 2020
Contributor
Author
irfansharif
left a comment
There was a problem hiding this comment.
Thanks for the review!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @arulajmani and @tbg)
pkg/cmd/roachtest/versionupgrade.go, line 523 at r1 (raw file):
Previously, arulajmani (Arul Ajmani) wrote…
Could you update this to
mv artifacts/acceptance/version-upgrade/run_1/logs/${i}.unredacted/checkpoint-*.tgz \while we're here as well?
Done.
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And address fallout from
roachprodchanges around clusterinitialization (#51329). Touches #54761.
Release note: None