sql: add issue link to ALTER TABLE DROP COLUMN with sql_safe_updates#55248
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 20, 2020
Merged
Conversation
Member
|
This change is |
thoszhang
approved these changes
Oct 7, 2020
thoszhang
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @lucy-zhang)
pkg/sql/alter_table.go, line 341 at r1 (raw file):
err = errors.WithIssueLink(err, issuelink.IssueLink{ IssueURL: "https://github.com/cockroachdb/cockroach/issues/46541", Detail: "when used in an explicit combined with other schema " +
You left out transaction
pkg/sql/alter_table.go, line 343 at r1 (raw file):
Detail: "when used in an explicit combined with other schema " + "changes to the same table, DROP COLUMN can result in data " + "loss if the other schema change fails or is canceled",
if one of the other schema changes...?
5bfd19d to
ceff786
Compare
Explicit transactions with drop column are very dangerous. Inform the user. Touches cockroachdb#51863. Release note (sql change): Added a note to inform users with an issue link when attempting potentially hazardous DROP COLUMN operations when sql_safe_updates is enabled.
ceff786 to
c029cc4
Compare
Contributor
Author
|
bors r=lucy-zhang |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit transactions with drop column are very dangerous. Inform the user.
Touches #51863.
Release note (sql change): Added a note to inform users with an issue link
when attempting potentially hazardous DROP COLUMN operations when
sql_safe_updates is enabled.