ui: extend diagnostics column to allow activate and download reports#55164
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 20, 2020
Merged
ui: extend diagnostics column to allow activate and download reports#55164craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
a94a8c2 to
b7a3fad
Compare
dhartunian
approved these changes
Oct 15, 2020
Collaborator
dhartunian
left a comment
There was a problem hiding this comment.
@koorosh really appreciate the detail in the commit message. Nice work!
Reviewed 7 of 7 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
dhartunian
requested changes
Oct 15, 2020
Collaborator
dhartunian
left a comment
There was a problem hiding this comment.
@koorosh I am expecting this PR to bump the admin-ui-components version, am I missing something?
Reviewable status:
Previously, Statements table had a Diagnostics column which allowed users to request diagnostics reports for the first time and then displayed status for requested report only. As result it wasn't possible to download already generated report or request new one report from statements table. With current changes, Diagnostics column allows to request new reports everytime when previous reports are generated. Also it provides a list with links to download previous reports. The main change is to provide a list of available (or requested) reports for every statement (instead of a single, most recent report as it was before). Then extracted `StatementsPage` component (from `admin-ui-components` package) handles all rendering logic for this list of reports. Minor changes: - `WAITING FOR QUERY` status is renamed to `WAITING` for new design - `getDiagnosticsStatus` utility function is reused to reduce code duplication Resolves: cockroachdb#50824 Release note (admin ui change): Diagnostics column (on statements table) has been changed and includes `Activate` button and dropdown list to download completed reports. Also diagnostics badge status is changed from `WAITING FOR QUERY` to `WAITING`.
b7a3fad to
28c4f9e
Compare
Contributor
Author
@dhartunian , you're definitely right, already updated with bumped version. Thanks! |
dhartunian
approved these changes
Oct 19, 2020
Collaborator
dhartunian
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status:
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This was referenced Oct 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #50824
Depends on cockroachdb/admin-ui-components#31Depends on cockroachdb/yarn-vendored#42Previously, Statements table had a Diagnostics column which allowed
users to request diagnostics reports for the first time and then
displayed status for requested report only. As result it wasn't
possible to download already generated report or request new one
report from the statements table.
With current changes, Diagnostics column allows requesting new
reports every time when previous reports are generated.
Also, it provides a list with links to download previous reports.
The main change is to provide a list of available (or requested)
reports for every statement (instead of a single, most recent
report as it was before). Then extracted
StatementsPagecomponent(from
admin-ui-componentspackage) handles all rendering logicfor this list of reports.
Minor changes:
WAITING FOR QUERYstatus is renamed toWAITINGfor new designgetDiagnosticsStatusutility function is reused to reduce codeduplication
Release note (admin ui change): Diagnostics column (on statements table)
has been changed and includes
Activatebutton and dropdown list todownload completed reports. Also, diagnostics badge status is changed from
WAITING FOR QUERYtoWAITING