cli: automatically detect SQL commands in tests#54932
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 30, 2020
Merged
cli: automatically detect SQL commands in tests#54932craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Prior to this change, every new SQL-only client command needed to be recognized by the `isSQLCommand` function in `cli_test.go`. This was a snag because nothing in the "main" code was suggesting this was necessary, and failure to do so would cause extremely obscure EOF connection errors during tests. This patch improves the situation by automatically recognizing the SQL commands in tests. Release note: None
Member
|
This change is |
irfansharif
approved these changes
Sep 29, 2020
tbg
approved these changes
Sep 30, 2020
Contributor
Author
|
TFYR bors=tbg,irfansharif |
Contributor
Author
|
bors r=tbg,irfansharif |
Contributor
|
Build succeeded: |
This was referenced Sep 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivated by seeing @spaskob and @adityamaru run into this twice in a month.
Prior to this change, every new SQL-only client command needed to be
recognized by the
isSQLCommandfunction incli_test.go. This was asnag because nothing in the "main" code was suggesting this was
necessary, and failure to do so would cause extremely obscure EOF
connection errors during tests.
This patch improves the situation by automatically recognizing
the SQL commands in tests.
Release note: None