sql: fix a bug tracking spans in a backfill#54900
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 29, 2020
Merged
sql: fix a bug tracking spans in a backfill#54900craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Fixes a bug introduced in cockroachdb#54755 whereby we'd always subtract from the original set of spans rather than from the updated set of spans meaning that we could backfill the same span multiple times. Fixes cockroachdb#54775. Release note: None
Member
|
This change is |
thoszhang
approved these changes
Sep 29, 2020
thoszhang
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Contributor
Author
|
bors r=lucy-zhang |
Contributor
|
Build succeeded: |
This was referenced Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #54755 whereby we'd always subtract from the original
set of spans rather than from the updated set of spans meaning that we could
backfill the same span multiple times.
Fixes #54775.
Release note: None