backupccl: fix bug due to transaction restart while publishing descri…#54748
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 24, 2020
Merged
Conversation
…ptors Before this patch, if a restart occurred while trying to publish descriptors, we would short-circuit publishing the descriptors on the subsequent attempt. The approach was validated by stressing `TestBackupRestoreResume` with the patch in cockroachdb#54695 which previously reproduced the failure immediately. Release note (bug fix): Fixed a bug whereby a transaction restart at the wrong moment during a restore could leave descriptors offline after the restore completed successfully.
Member
|
This change is |
thoszhang
approved these changes
Sep 24, 2020
thoszhang
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @adityamaru)
adityamaru
approved these changes
Sep 24, 2020
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
Contributor
|
Just catching up on this, does this need a backport into 20.2? |
Contributor
Author
Yes indeed. We could potentially go further back too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ptors
Before this patch, if a restart occurred while trying to publish descriptors,
we would short-circuit publishing the descriptors on the subsequent attempt.
The approach was validated by stressing
TestBackupRestoreResumewith thepatch in #54695 which previously
reproduced the failure immediately.
Release note (bug fix): Fixed a bug whereby a transaction restart at the
wrong moment during a restore could leave descriptors offline after the
restore completed successfully.