workload: add back injection of stats for TPC-C tables at start of workload#54713
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 23, 2020
Merged
workload: add back injection of stats for TPC-C tables at start of workload#54713craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
…rkload This commit adds back the injection of statistics for some tables at the start of the TPC-C workload that had been removed by mistake in cockroachdb#35349. The removal caused a regression in TPC-C since it caused some plans to change due to the lack of statistics at the beginning of the benchmark. Adding the stats back should fix the regression. Fixes cockroachdb#54702 Release note: None
Member
|
This change is |
Member
|
Unfortunately, I tried using |
RaduBerinde
approved these changes
Sep 23, 2020
Collaborator
Author
|
TFTR! I guess we'll have to regenerate the fixtures too... but I assume that doesn't affect this PR? |
Collaborator
Author
|
bors r+ |
This was referenced Sep 23, 2020
Merged
Merged
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds back the injection of statistics for some tables at the
start of the TPC-C workload that had been removed by mistake in #35349.
The removal caused a regression in TPC-C since it caused some plans to change
due to the lack of statistics at the beginning of the benchmark. Adding the
stats back should fix the regression.
Fixes #54702
Release note: None