workload/schemachange: add enum support#54351
Conversation
|
This change is |
otan
left a comment
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @otan)
pkg/workload/schemachange/schemachange.go, line 1104 at r1 (raw file):
AND typcategory = 'E' AND typname = $1 ORDER BY gen_random_uuid();`, name.Object())
should we sort by enum order here, and makerng would be in charge of picking a randomly assigned element (for reproducible runs)?
(also, not sure I follow why we are sorting by random)
This commit adds support for creating enums, adding enum columns, and using enums to insert data into rows. This found a bug so I'm pleased. Release note: None
904adaa to
4028be7
Compare
ajwerner
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/workload/schemachange/schemachange.go, line 1104 at r1 (raw file):
Previously, otan (Oliver Tan) wrote…
should we sort by enum order here, and make
rngwould be in charge of picking a randomly assigned element (for reproducible runs)?
(also, not sure I follow why we are sorting by random)
No good reason. Done.
otan
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
|
TFTR! bors r=otan |
|
Build failed (retrying...): |
|
Build succeeded: |
This commit adds support for creating enums, adding enum columns, and using
enums to insert data into rows. This found a bug so I'm pleased.
Release note: None