Skip to content

sql,importccl: adopt jobs.TestingSetAdoptAndCancelIntervals#53898

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/remove-last-manual-updates-to-DefaultAdoptInterval
Sep 8, 2020
Merged

sql,importccl: adopt jobs.TestingSetAdoptAndCancelIntervals#53898
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/remove-last-manual-updates-to-DefaultAdoptInterval

Conversation

@ajwerner
Copy link
Copy Markdown
Contributor

@ajwerner ajwerner commented Sep 3, 2020

These were missed in #53589.

These settings would really be much better served by a cluster setting.

Release justification: non-production code change.

Release note: None

These were missed in cockroachdb#53589.

These settings would really be much better served by a cluster setting.

Release justification: non-production code change.

Release note: None
@ajwerner ajwerner requested review from a team, pbardea and spaskob and removed request for a team September 3, 2020 13:36
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@pbardea pbardea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #53899 for tracking.

@ajwerner
Copy link
Copy Markdown
Contributor Author

ajwerner commented Sep 8, 2020

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 8, 2020

Build succeeded:

@craig craig bot merged commit e20f17e into cockroachdb:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants