kvserver: unskip TestStoreRangeMergeConcurrentRequests#53777
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 1, 2020
Merged
Conversation
Member
|
This change is |
I `stressrace`ed it for ~4K runs and couldn't repro. ``` 4456 runs so far, 0 failures, over 28m5s ``` In all likelihood, this test was fixed by @andreimatei's changes around the range descriptor cache. In particular, cockroachdb#51437 and/or cockroachdb#51395. Release justification: Non production code change Release note: None Fixes cockroachdb#50795
ae5c9ad to
15a6062
Compare
andreimatei
reviewed
Sep 1, 2020
Contributor
andreimatei
left a comment
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I
stressraceed it for ~4K runs and couldn't repro.In all likelihood, this test was fixed by @andreimatei's changes around
the range descriptor cache. In particular, #51437 and/or #51395.
Fixes #50795
Release justification: Non production code change
Release note: None