roachtest: update jobs/mixed-version to use RESTORE#53752
roachtest: update jobs/mixed-version to use RESTORE#53752craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
miretskiy
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @spaskob)
866c7ba to
1295d87
Compare
spaskob
left a comment
There was a problem hiding this comment.
Thank you for fixing this!
Reviewable status:
pkg/cmd/roachtest/mixed_version_jobs.go, line 330 at r3 (raw file):
t.Fatal(err) } warehouses := 10
curious why 200 is too much
pbardea
left a comment
There was a problem hiding this comment.
I was under the impression that there was a descriptor migration - but the issue actually seems to be a bug in restore with respect to descriptor rewriting. Going to get a change out soon to fix that separately. That will need to go in first since this test will just fail on that bug.
Reviewable status:
pkg/cmd/roachtest/mixed_version_jobs.go, line 330 at r3 (raw file):
Previously, spaskob (Spas Bojanov) wrote…
curious why 200 is too much
I found that we just needed the job to last as long as the test did, and from my runs 10 seemed to be sufficient.
Also of note, now that we're using restore we need to use a fixture that we have already backed up. We don't have a 200 TPCC backup, but we do have a 100 TPCC one that we can use, but I didn't find the need for it from my runs.
Previously, this roachtest would use IMPORT, but IMPORTs do not support being run in mixed-version clusters. This test now uses RESTORE as the job under test. Release justification: non-production code change. Release note: None
1295d87 to
01e9e98
Compare
|
Rebased on top of the mixed-version fix from last week. roachtest passes locally and on roachprod. |
|
Merging since the only change was the rebase. |
|
Build failed (retrying...): |
|
Build succeeded: |
Previously, this roachtest would use IMPORT, but IMPORTs do not support
being run in mixed-version clusters. This test now uses RESTORE as the
job under test.
Fixes #52284.
Fixes #52075.
Fixes #51699.
Fixes #51186.
Fixes #51100.
Fixes #50026.
Fixes #48315.
Fixes #48194.
Fixes #50535.
Release justification: non-production code change.
Release note: None