sql: fix TestTruncateCompletion#53711
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 1, 2020
Merged
Conversation
The table data is deleted asynchronously by the GC job. It's not obvious to me why this wasn't flakey before. The work in cockroachdb#53589 to generally speed up job adoption seems to have revealed the flake that I think existed before the change. This test used to fail under stress 2 minutes. I've run it for 6 now and so far so good. Release justification: non-production code changes Release note: None
Member
|
This change is |
rohany
approved these changes
Aug 31, 2020
Contributor
rohany
left a comment
There was a problem hiding this comment.
Yeah not sure how this wasn’t caught earlier
Contributor
Author
|
TFTR! bors r=rohany |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table data is deleted asynchronously by the GC job. It's not obvious to me
why this wasn't flakey before. The work in #53589 to generally speed up job
adoption seems to have revealed the flake that I think existed before the
change. This test used to fail under stress 2 minutes. I've run it for 6
now and so far so good.
Release justification: non-production code changes
Release note: None