Skip to content

geos: fix compile error with -Wsign-conversion#53702

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
otan-cockroach:wkbwriter_fix
Sep 1, 2020
Merged

geos: fix compile error with -Wsign-conversion#53702
craig[bot] merged 1 commit intocockroachdb:masterfrom
otan-cockroach:wkbwriter_fix

Conversation

@otan
Copy link
Copy Markdown
Contributor

@otan otan commented Aug 31, 2020

Not sure why this wasn't caught in #53647.

Release justification: bug fixes and low-risk updates to new
functionality

Release note: None

@otan otan requested review from a team and sumeerbhola August 31, 2020 19:37
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Not sure why this wasn't caught in cockroachdb#53647.

Release justification: bug fixes and low-risk updates to new
functionality

Release note: None
@otan
Copy link
Copy Markdown
Contributor Author

otan commented Aug 31, 2020

Copy link
Copy Markdown
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@otan
Copy link
Copy Markdown
Contributor Author

otan commented Aug 31, 2020

bors r=sumeerbhola

Copy link
Copy Markdown
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @petermattis do you know why this wasn't caught in CI, but was in https://teamcity.cockroachdb.com/viewLog.html?buildId=2235367&tab=buildResultsDiv&buildTypeId=Cockroach_UnitTests_Testrace?

I don't know. Maybe some artifact reuse thingy.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@otan
Copy link
Copy Markdown
Contributor Author

otan commented Aug 31, 2020

Maybe some artifact reuse thingy.

ick.

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 31, 2020

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 1, 2020

Build succeeded:

@craig craig bot merged commit f2056ba into cockroachdb:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants