roachtest: re-enable acceptance/bank/zerosum-splits (revert #34080) #53695
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Sep 1, 2020
Merged
roachtest: re-enable acceptance/bank/zerosum-splits (revert #34080) #53695craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
This test had been flaking earlier in 2019 due to unclean graceful shutdowns. Since we've heavily reworked that logic since, let's give the test a second chance. Release justification: non-production code changes Release note: None
PR cockroachdb#34080 which intended to skip `bank/zerosum-restarts`, mistakenly skipped `bank/zerosum-splits` instead. (As `zerosum-restarts` had been skipped already prior) There was no reason to skip `zerosum-splits`, so this commit re-enables it. Release justification: non-production code changes Release note: None
Member
|
This change is |
irfansharif
approved these changes
Aug 31, 2020
Contributor
Author
|
bors r=irfansharif |
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit from #53693.
PR #34080 which intended to skip
bank/zerosum-restarts,mistakenly skipped
bank/zerosum-splitsinstead.(As
zerosum-restartshad been skipped already prior)There was no reason to skip
zerosum-splits, so this commitre-enables it.
Release justification: non-production code changes
Release note: None