Skip to content

sql: fix enums in pg_catalog.pg_attrdef#53692

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rohany:pgattrdef
Sep 1, 2020
Merged

sql: fix enums in pg_catalog.pg_attrdef#53692
craig[bot] merged 1 commit intocockroachdb:masterfrom
rohany:pgattrdef

Conversation

@rohany
Copy link
Copy Markdown
Contributor

@rohany rohany commented Aug 31, 2020

Fixes #53687.

This commit ensures that enums are displayed with their logical
representation in the catalog table pg_catalog.pg_attrdef.

Release justification: bug fix
Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rohany rohany marked this pull request as ready for review September 1, 2020 01:39
@rohany rohany requested a review from rafiss September 1, 2020 01:39
Copy link
Copy Markdown
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! as long as other tests aren't affected

Fixes cockroachdb#53687.

This commit ensures that enums are displayed with their logical
representation in the catalog table `pg_catalog.pg_attrdef`.

Release justification: bug fix
Release note: None
@rohany
Copy link
Copy Markdown
Contributor Author

rohany commented Sep 1, 2020

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 1, 2020

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql: pg_catalog.pg_attrdef.adbin formats enum values with physical representation instead of logical representation

3 participants