roachtest: bump PredecessorVersion(20.2) to 20.1.5#53668
Closed
arulajmani wants to merge 2 commits intocockroachdb:masterfrom
Closed
roachtest: bump PredecessorVersion(20.2) to 20.1.5#53668arulajmani wants to merge 2 commits intocockroachdb:masterfrom
arulajmani wants to merge 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
jlinder
reviewed
Aug 31, 2020
| @@ -1158,7 +1158,7 @@ func PredecessorVersion(buildVersion version.Version) (string, error) { | |||
| // (see runVersionUpgrade). The same is true for adding a new key to this | |||
Collaborator
There was a problem hiding this comment.
Does this comment need to be followed to update the fixtures (as was done for these releases)?
Collaborator
Author
There was a problem hiding this comment.
Yeah, I think so. Seems like checkpointing the 20.1.5 fixtures requires the binaries to be downloadable from the homepage -- so I'm gonna wait on this PR until that's done.
4723dba to
3057acb
Compare
Collaborator
Author
|
@jlinder sorry for the delay on closing the loop on this, I've updated the checkpointing error message as well so that we don't run into this problem again. RFAL |
Release justification: change part of 20.1.5 release process Release note: None
The directory structure of logs is slightly different now that we have redacted logs, so the checkpoints are created in a different location. Update the (on purpose) error message to reference the correct location. Release note: None
3057acb to
2a3dcf3
Compare
Collaborator
Author
|
bors r=jlinder |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed: |
Collaborator
Author
|
closing this in favour of #54761 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release justification: change part of 20.1.5 release process
Release note: None