Skip to content

builtins: implement ST_ForceCollection#53643

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
erikgrinaker:st_forcecollection
Aug 31, 2020
Merged

builtins: implement ST_ForceCollection#53643
craig[bot] merged 1 commit intocockroachdb:masterfrom
erikgrinaker:st_forcecollection

Conversation

@erikgrinaker
Copy link
Copy Markdown
Contributor

@erikgrinaker erikgrinaker commented Aug 30, 2020

Some test cases deviate from PostGIS due to a bug in the WKT encoder (see #53632). The behavior of ST_ForceCollection is correct, but the WKT output does not accurately represent the resulting geometry. Not sure if we should wait for the upstream fix or merge this as-is.

Release justification: low risk, high benefit changes to existing functionality

Release note (sql change): Implement the geometry builtin
ST_ForceCollection.

Closes #48934.

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Aug 30, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Aug 30, 2020
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Aug 30, 2020

This change is Reviewable

@blathers-crl blathers-crl bot requested a review from otan August 30, 2020 14:01
@otan
Copy link
Copy Markdown
Contributor

otan commented Aug 30, 2020

Let's wait for the upstream changes (I'll patch GEOS with the relevant fix), should be able to do this Monday!

@otan otan mentioned this pull request Aug 30, 2020
Merged
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Aug 31, 2020

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@erikgrinaker
Copy link
Copy Markdown
Contributor Author

erikgrinaker commented Aug 31, 2020

Thanks for the dep bumps and fixes! Rebased onto master and updated tests.

@otan
Copy link
Copy Markdown
Contributor

otan commented Aug 31, 2020

bors r+

@erikgrinaker
builtins: implement ST_ForceCollection
dea9bf4 
Release justification: low risk, high benefit changes to existing functionality

Release note (sql change): Implement the geometry builtin
`ST_ForceCollection`.
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 31, 2020

Canceled.

@erikgrinaker
Copy link
Copy Markdown
Contributor Author

erikgrinaker commented Aug 31, 2020

Rebased to fix merge conflicts.

@otan
Copy link
Copy Markdown
Contributor

otan commented Aug 31, 2020

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 31, 2020

Build succeeded:

@craig craig bot merged commit cff29e7 into cockroachdb:master Aug 31, 2020
@jseldess jseldess mentioned this pull request Sep 15, 2020
Open
@erikgrinaker erikgrinaker deleted the st_forcecollection branch March 19, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@otan otan Awaiting requested review from otan

Assignees

No one assigned

Labels

O-community Originated from the community X-blathers-triaged blathers was able to find an owner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

geo/geomfn: implement ST_ForceCollection({geometry})

3 participants

@erikgrinaker @cockroach-teamcity @otan