Skip to content

opt: push limit into unconstrained partial index scan#53581

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
mgartner:push-limit-into-partial-index-scan
Aug 28, 2020
Merged

opt: push limit into unconstrained partial index scan#53581
craig[bot] merged 1 commit intocockroachdb:masterfrom
mgartner:push-limit-into-partial-index-scan

Conversation

@mgartner
Copy link
Copy Markdown
Contributor

This commit updates the PushLimitIntoConstrainedScan rule to push
limits into unconstrained partial index scans. The rule has been renamed
to PushLimitIntoFilteredScan to better reflect this new logic.

Release justification: This is a low-risk update to new functionality,
partial indexes.

Fixes #50828

Release note: None

@mgartner mgartner requested review from RaduBerinde and rytaft August 27, 2020 22:29
@mgartner mgartner requested a review from a team as a code owner August 27, 2020 22:29
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@mgartner mgartner force-pushed the push-limit-into-partial-index-scan branch from fff2bd2 to 09ab25d Compare August 27, 2020 22:31
Copy link
Copy Markdown
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgartner mgartner force-pushed the push-limit-into-partial-index-scan branch from 09ab25d to c996ce3 Compare August 28, 2020 00:39
This commit updates the PushLimitIntoConstrainedScan rule to push
limits into unconstrained partial index scans. The rule has been renamed
to PushLimitIntoFilteredScan to better reflect this new logic.

Release justification: This is a low-risk update to new functionality,
partial indexes.

Release note: None
@mgartner mgartner force-pushed the push-limit-into-partial-index-scan branch from c996ce3 to 41ed4ed Compare August 28, 2020 01:16
@mgartner
Copy link
Copy Markdown
Contributor Author

bors r=RaduBerinde

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 28, 2020

Build succeeded:

@craig craig bot merged commit 60e3bb6 into cockroachdb:master Aug 28, 2020
@mgartner mgartner deleted the push-limit-into-partial-index-scan branch August 31, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

opt: PushLimitIntoConstrainedScan should push limits into partial index scans

3 participants