backupccl: checksum backup manifest#53298
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 24, 2020
Merged
Conversation
This commit checksums that backup manifest when it is written. This helps detect issues such as random bitflips of the manifest data. When writing a backup manifest, it will also write the checksum of that file to a file with a "-CHECKSUM" suffix appended to the manifest file name. The checksum is keyed on the encryption key if the backup is encrypted. When reading manifests, we check for the '...-CHECKSUM' file, and if one is present, we compare the checksums. If there isn't one present, we will continue as we did before. This allows backwards compatibility with old backups. Release note: None
Member
|
This change is |
dt
approved these changes
Aug 24, 2020
Contributor
Author
|
TFTR! |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit checksums that backup manifest when it is written. This
helps detect issues such as random bitflips of the manifest file.
When writing a backup manifest, it will also write the checksum of that
file to a file with a "-CHECKSUM" suffix appended to the manifest file
name. When reading manifests, we check for the '...-CHECKSUM' file,
and if one is present, we compare the checksums. If there isn't one
present, we will continue as we did before. This allows backwards
compatibility with old backups.
Fixes #52061.
Release note: None