sql: avoid flake in scan_test#52769
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 18, 2020
Merged
Conversation
Member
|
This change is |
asubiotto
approved these changes
Aug 13, 2020
Contributor
asubiotto
left a comment
There was a problem hiding this comment.
An atomic should be fine in the grand scheme of things, but this solution
Reviewable status:
complete! 1 of 0 LGTMs obtained
jbowens
reviewed
Aug 17, 2020
Contributor
jbowens
left a comment
There was a problem hiding this comment.
Is this good to merge @jordanlewis? Seeing more of this failure today: #52683
Reviewable status:
pkg/sql/scan_test.go, line 175 at r1 (raw file):
for _, batch := range batchSizes { row.TestingSetKVBatchSize(int64(batch))
accident?
The new sqlliveness package doesn't get along well with the kv batch size "atomic", so turn down its check frequency in the test. Possibly we should make the "atomic" actually atomic, but I'm not sure about the runtime performance change. Fixes cockroachdb#52683 Release note: None
Contributor
|
Jordan's out so merging this on his behalf bors r=asubiotto |
Contributor
|
Thanks @asubiotto |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new sqlliveness package doesn't get along well with the kv batch
size "atomic", so turn down its check frequency in the test. Possibly we
should make the "atomic" actually atomic, but I'm not sure about the
runtime performance change.
Fixes #52683
Release note: None