sql: add version field to PrivilegeDescriptor#52701
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 12, 2020
Merged
sql: add version field to PrivilegeDescriptor#52701craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
rohany
approved these changes
Aug 12, 2020
Contributor
rohany
left a comment
There was a problem hiding this comment.
Make sure to audit all places that the privilege descriptor is created
6b08b06 to
df336d3
Compare
Contributor
Author
Yep, almost missed one in |
Add version field to PrivilegeDescriptor to allow for validating the owner field. PrivilegeDescriptors pre 20.1 will have InitialVersion by default and validation will not be performed for the owner field. PrivilegeDescriptors 20.2 and onward will have OwnerVersion and validation will be performed on the owner field. Release note: None
df336d3 to
610a468
Compare
Contributor
Author
|
bors r=rohany |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add version field to PrivilegeDescriptor to allow for
validating the owner field.
PrivilegeDescriptors pre 20.1 will have InitialVersion by default
and validation will not be performed for the owner field.
PrivilegeDescriptors 20.2 and onward will have OwnerVersion
and validation will be performed on the owner field.
Release note: None
Fixes #51930