Skip to content

kv/kvtenant: rename Proxy to Connector#52599

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/proxyConnector
Aug 12, 2020
Merged

kv/kvtenant: rename Proxy to Connector#52599
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/proxyConnector

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Aug 10, 2020

See discussion in #50503. We found "proxy" confusing, because the object was
in the same process as the rest of the SQL-only process instead of run as a
stand-alone component. "Connector" doesn't create the same confusion.

@nvb nvb requested review from knz and tbg August 10, 2020 21:42
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@lunevalex lunevalex added the A-multitenancy Related to multi-tenancy label Aug 11, 2020
@nvb nvb force-pushed the nvanbenschoten/proxyConnector branch from c009f64 to e82c0a7 Compare August 11, 2020 20:42
See discussion in cockroachdb#50503. We found "proxy" confusing, because the object was
in the same process as the rest of the SQL-only process instead of run as a
stand-alone component. "Connector" doesn't create the same confusion.
@nvb nvb force-pushed the nvanbenschoten/proxyConnector branch from e82c0a7 to 5416c9c Compare August 11, 2020 22:05
@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented Aug 12, 2020

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 12, 2020

Build succeeded:

@craig craig bot merged commit 71566fd into cockroachdb:master Aug 12, 2020
@nvb nvb deleted the nvanbenschoten/proxyConnector branch August 14, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-multitenancy Related to multi-tenancy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants