sql/pgwire: add regression test for varchar OIDs in RowDescription#52352
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 5, 2020
Merged
sql/pgwire: add regression test for varchar OIDs in RowDescription#52352craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
jordanlewis
approved these changes
Aug 4, 2020
Member
jordanlewis
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis and @rafiss)
pkg/sql/pgwire/testdata/pgtest/row_description, line 220 at r1 (raw file):
{"Type":"ReadyForQuery","TxStatus":"I"} # tab4 is a regression test for #51360
Please include a brief description of the issue so its more obvious what this test is doing without having to go to GitHub
See issue cockroachdb#51360. The bug described in it was fixed somewhat accidentally, do this test will verify that we don't regress again. Release note: None
c37668d to
b960095
Compare
rafiss
commented
Aug 4, 2020
Collaborator
Author
rafiss
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/sql/pgwire/testdata/pgtest/row_description, line 220 at r1 (raw file):
Previously, jordanlewis (Jordan Lewis) wrote…
Please include a brief description of the issue so its more obvious what this test is doing without having to go to GitHub
Done
Collaborator
Author
|
bors r=jordanlewis |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #51360. The bug described in it was fixed somewhat
accidentally, so this test will verify that we don't regress again.
Release note: None