sql: remove local execution of projectSetNode and implement ConstructProjectSet in the new factory#52146
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Aug 4, 2020
Merged
Conversation
Member
|
This change is |
5a7f7f3 to
a243d08
Compare
Member
Author
|
First two commits are in a separate PR. |
77ab99c to
e0eaf6e
Compare
asubiotto
approved these changes
Aug 4, 2020
Contributor
asubiotto
left a comment
There was a problem hiding this comment.
Last two commits 
Reviewed 5 of 5 files at r3, 5 of 5 files at r4.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)
|
🎉 All dependencies have been resolved ! |
We have project set processor which is always planned for `projectSetNode`, so this commit removes the dead code of its local execution. Additionally, it removes some unused fields and cleans up cancellation check of the processor. Release note: None
Release note: None
e0eaf6e to
fe44189
Compare
Member
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #52108.
sql: remove local execution of projectSetNode
We have project set processor which is always planned for
projectSetNode, so this commit removes the dead code of its localexecution. Additionally, it removes some unused fields and cleans up
cancellation check of the processor.
Release note: None
sql: implement ConstructProjectSet in the new factory
Addresses: #47473.
Release note: None