Conversation
|
This change is |
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained
ajwerner
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ts/timespan.go, line 100 at r2 (raw file):
return fmt.Errorf( "cannot query time series in the future (start time %d was greater than "+ "cutoff for current sample period %d); current time: %s; sample duration: %s",
you need a %d or %v
df87bf9 to
03c83b7
Compare
andreimatei
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ts/timespan.go, line 100 at r2 (raw file):
Previously, ajwerner wrote…
you need a
%dor%v
switched to proper times
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4.
Reviewable status:
A test had a non-sensically short duration when running locally. Actually running this test with such a short duration causes it to fail cause the metrics query that it wants to do errors out because the duration is too small in comparison with the downsampling period. Release note: None
Release note: None
03c83b7 to
f38ebe1
Compare
andreimatei
left a comment
There was a problem hiding this comment.
bors r+
Reviewable status:
|
Build succeeded: |
See individual commits.