kvserver: fix flake in TestReplicaGCQueueDropReplicaDirect#51860
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 24, 2020
Merged
kvserver: fix flake in TestReplicaGCQueueDropReplicaDirect#51860craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
nvb
approved these changes
Jul 23, 2020
Contributor
nvb
left a comment
There was a problem hiding this comment.
LGTM. Thanks for tracking this down!
Author
|
bors r+ |
9cc6550 to
3e99842
Compare
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Member
|
bors r+ |
Author
|
bors retry |
Fixes cockroachdb#51263 A previous change that switched this test from multiTestContect to using TestCluster introduced a regression. The test did not properly wait/replicate the scratch range, so it sometimes failed. This change adds deterministic replication for the scrath range, which fixes this issue. Release note: None
3e99842 to
5e16dfb
Compare
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51263
A previous change that switched this test from multiTestContect to using TestCluster introduced a regression. The test did not properly wait/replicate the scratch range, so it sometimes failed. This change adds deterministic replication for the scrath range, which fixes this issue.
Release note: None