Skip to content

roachpb: strongly type RangeGeneration#51605

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/rangeGen
Jul 21, 2020
Merged

roachpb: strongly type RangeGeneration#51605
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/rangeGen

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Jul 20, 2020

Noticed while reviewing #51437.

@nvb nvb requested a review from andreimatei July 20, 2020 15:53
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@nvb nvb force-pushed the nvanbenschoten/rangeGen branch from c171b12 to 4559445 Compare July 20, 2020 17:13
Copy link
Copy Markdown
Contributor

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)

@nvb nvb force-pushed the nvanbenschoten/rangeGen branch from 4559445 to 529aa82 Compare July 20, 2020 19:49
@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented Jul 21, 2020

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 21, 2020

Build succeeded

@craig craig bot merged commit 8354896 into cockroachdb:master Jul 21, 2020
@nvb nvb deleted the nvanbenschoten/rangeGen branch July 23, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants