backupccl: add a basic test with incremental backup on types#51513
backupccl: add a basic test with incremental backup on types#51513craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
pkg/ccl/backupccl/backup_test.go
Outdated
| sqlDB.Exec(t, `RESTORE TABLE d.t FROM 'nodelocal://0/test/' WITH into_db = 'd2'`) | ||
| sqlDB.CheckQueryResults(t, `SELECT 'hello'::d2.newname`, [][]string{{"hello"}}) | ||
|
|
||
| // Now explicitly use the `INCREMENTAL` backup statement. |
There was a problem hiding this comment.
FWIW I don't see much need for this test -- of type backups -- to bother testing via both incremental syntaxes - I think the part above is sufficient to prove it works.
If we did want to test more cases though, I might say either adding a value to a type, a cross-db type reference or a db or cluster backup instead of single table -- those all seem more likely to have type-backup interactions than the two different incremental syntaxes. That said, I wouldn't say any of it is a requirement to merge -- the test above is already better than what we have now.
There was a problem hiding this comment.
FWIW I don't see much need for this test -- of type backups -- to bother testing via both incremental syntaxes - I think the part above is sufficient to prove it works.
Oh ok, I wasn't sure there was a difference.
I might say either adding a value to a type
I'll be adding more tests here as more of the ALTER TYPE/DROP TYPE commands get implemented.
cross-db type reference
I've disabled these :)
db or cluster backup instead of single table
These will be easier once DROP TYPE lands.
Work for cockroachdb#50321. As of now, only the `ALTER TYPE ... RENAME` command has been implemented, so add a basic test here for incremental backup picking up changes to the types name. Release note: None
|
bors r=dt |
Build failed (retrying...) |
Canceled (will resume) |
Build succeeded |
Work for #50321.
As of now, only the
ALTER TYPE ... RENAMEcommand has beenimplemented, so add a basic test here for incremental backup picking up
changes to the types name.
Release note: None