Reviewed 8 of 8 files at r1.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @otan)

pkg/geo/geomfn/validity_check.go, line 21 at r1 (raw file):

type ValidDetail struct {
	IsValid bool
	// Reason is only populated if IsValid = true.

shouldn't this be IsValid=false?

pkg/geo/geomfn/validity_check.go, line 23 at r1 (raw file):

	// Reason is only populated if IsValid = true.
	Reason string
	// InvalidLocation is only populated if IsValid = true.

ditto

pkg/geo/geos/geos.go, line 623 at r1 (raw file):

// means that self-intersecting rings forming holes are considered valid.
// It returns a bool representing whether it is valid, a string giving a reason for
// invalidity, an EWKB representing the location things are invalid at.

[nit] and an EWKB

pkg/sql/sem/builtins/geo_builtins.go, line 2352 at r1 (raw file):

			infoBuilder{
				info:         `Returns whether the geometry is valid as defined by the OGC spec.`,
				libraryUsage: usesGEOS,

Just out of curiosity: is this field purely for documentation purposes? Is there a way we could test that this matches reality? (Obviously that would be a different PR...)

pkg/sql/sem/builtins/geo_builtins.go, line 2440 at r1 (raw file):

			types.Geometry,
			infoBuilder{
				info:         "Returns a valid form of the given geometry.",

Do you need to mention the OGC spec here? Or not necessary?

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rytaft)

pkg/geo/geomfn/validity_check.go, line 21 at r1 (raw file):

Done.

pkg/geo/geomfn/validity_check.go, line 23 at r1 (raw file):

Done.

pkg/geo/geos/geos.go, line 623 at r1 (raw file):

Done.

pkg/sql/sem/builtins/geo_builtins.go, line 2352 at r1 (raw file):

Yep - only docs.
Not sure about detection - requires some fancy go parsing i reckon.

pkg/sql/sem/builtins/geo_builtins.go, line 2440 at r1 (raw file):

Done.

Reviewed 4 of 4 files at r2.
Reviewable status: complete! 1 of 0 LGTMs obtained

pkg/sql/sem/builtins/geo_builtins.go, line 2352 at r1 (raw file):

Sounds good -- probably not high priority